lkml.org 
[lkml]   [2019]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 3/4] firmware/qcom_scm: Add scm call to handle smmu errata
    On Sun 09 Sep 23:25 PDT 2018, Vivek Gautam wrote:

    > Qcom's smmu-500 needs to toggle wait-for-safe sequence to
    > handle TLB invalidation sync's.
    > Few firmwares allow doing that through SCM interface.
    > Add API to toggle wait for safe from firmware through a
    > SCM call.
    >
    > Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>

    Reviewed-by: Bjorn Andersson <bjorn.andersson@linaro.org>

    Regards,
    Bjorn

    > ---
    > drivers/firmware/qcom_scm-32.c | 5 +++++
    > drivers/firmware/qcom_scm-64.c | 13 +++++++++++++
    > drivers/firmware/qcom_scm.c | 6 ++++++
    > drivers/firmware/qcom_scm.h | 5 +++++
    > include/linux/qcom_scm.h | 2 ++
    > 5 files changed, 31 insertions(+)
    >
    > diff --git a/drivers/firmware/qcom_scm-32.c b/drivers/firmware/qcom_scm-32.c
    > index 7293e5efad69..2d301ad053f8 100644
    > --- a/drivers/firmware/qcom_scm-32.c
    > +++ b/drivers/firmware/qcom_scm-32.c
    > @@ -639,3 +639,8 @@ int __qcom_scm_io_writel_atomic(struct device *dev, phys_addr_t addr,
    > {
    > return -ENODEV;
    > }
    > +
    > +int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, bool enable)
    > +{
    > + return -ENODEV;
    > +}
    > diff --git a/drivers/firmware/qcom_scm-64.c b/drivers/firmware/qcom_scm-64.c
    > index 6bf55403f6e3..f13bcabc5d78 100644
    > --- a/drivers/firmware/qcom_scm-64.c
    > +++ b/drivers/firmware/qcom_scm-64.c
    > @@ -590,3 +590,16 @@ int __qcom_scm_io_writel_atomic(struct device *dev, phys_addr_t addr,
    > return qcom_scm_call_atomic(dev, QCOM_SCM_SVC_IO, QCOM_SCM_IO_WRITE,
    > &desc, &res);
    > }
    > +
    > +int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev, bool en)
    > +{
    > + struct qcom_scm_desc desc = {0};
    > + struct arm_smccc_res res;
    > +
    > + desc.args[0] = QCOM_SCM_CONFIG_ERRATA1_CLIENT_ALL;
    > + desc.args[1] = en;
    > + desc.arginfo = QCOM_SCM_ARGS(2);
    > +
    > + return qcom_scm_call_atomic(dev, QCOM_SCM_SVC_SMMU_PROGRAM,
    > + QCOM_SCM_CONFIG_ERRATA1, &desc, &res);
    > +}
    > diff --git a/drivers/firmware/qcom_scm.c b/drivers/firmware/qcom_scm.c
    > index 36da0000b37f..5f15cc2e9f69 100644
    > --- a/drivers/firmware/qcom_scm.c
    > +++ b/drivers/firmware/qcom_scm.c
    > @@ -353,6 +353,12 @@ int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare)
    > }
    > EXPORT_SYMBOL(qcom_scm_iommu_secure_ptbl_init);
    >
    > +int qcom_scm_qsmmu500_wait_safe_toggle(bool en)
    > +{
    > + return __qcom_scm_qsmmu500_wait_safe_toggle(__scm->dev, en);
    > +}
    > +EXPORT_SYMBOL(qcom_scm_qsmmu500_wait_safe_toggle);
    > +
    > int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val)
    > {
    > return __qcom_scm_io_readl(__scm->dev, addr, val);
    > diff --git a/drivers/firmware/qcom_scm.h b/drivers/firmware/qcom_scm.h
    > index bb176107f51e..89a822c23e33 100644
    > --- a/drivers/firmware/qcom_scm.h
    > +++ b/drivers/firmware/qcom_scm.h
    > @@ -103,10 +103,15 @@ extern int __qcom_scm_restore_sec_cfg(struct device *dev, u32 device_id,
    > u32 spare);
    > #define QCOM_SCM_IOMMU_SECURE_PTBL_SIZE 3
    > #define QCOM_SCM_IOMMU_SECURE_PTBL_INIT 4
    > +#define QCOM_SCM_SVC_SMMU_PROGRAM 0x15
    > +#define QCOM_SCM_CONFIG_ERRATA1 0x3
    > +#define QCOM_SCM_CONFIG_ERRATA1_CLIENT_ALL 0x2
    > extern int __qcom_scm_iommu_secure_ptbl_size(struct device *dev, u32 spare,
    > size_t *size);
    > extern int __qcom_scm_iommu_secure_ptbl_init(struct device *dev, u64 addr,
    > u32 size, u32 spare);
    > +extern int __qcom_scm_qsmmu500_wait_safe_toggle(struct device *dev,
    > + bool enable);
    > #define QCOM_MEM_PROT_ASSIGN_ID 0x16
    > extern int __qcom_scm_assign_mem(struct device *dev,
    > phys_addr_t mem_region, size_t mem_sz,
    > diff --git a/include/linux/qcom_scm.h b/include/linux/qcom_scm.h
    > index 6a5d0c98b328..46e6b1692998 100644
    > --- a/include/linux/qcom_scm.h
    > +++ b/include/linux/qcom_scm.h
    > @@ -62,6 +62,7 @@ extern int qcom_scm_set_remote_state(u32 state, u32 id);
    > extern int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare);
    > extern int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size);
    > extern int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare);
    > +extern int qcom_scm_qsmmu500_wait_safe_toggle(bool en);
    > extern int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val);
    > extern int qcom_scm_io_writel(phys_addr_t addr, unsigned int val);
    > extern int qcom_scm_io_readl_atomic(phys_addr_t addr, unsigned int *val);
    > @@ -100,6 +101,7 @@ qcom_scm_set_remote_state(u32 state,u32 id) { return -ENODEV; }
    > static inline int qcom_scm_restore_sec_cfg(u32 device_id, u32 spare) { return -ENODEV; }
    > static inline int qcom_scm_iommu_secure_ptbl_size(u32 spare, size_t *size) { return -ENODEV; }
    > static inline int qcom_scm_iommu_secure_ptbl_init(u64 addr, u32 size, u32 spare) { return -ENODEV; }
    > +static inline int qcom_scm_qsmmu500_wait_safe_toggle(bool en) { return -ENODEV; }
    > static inline int qcom_scm_io_readl(phys_addr_t addr, unsigned int *val) { return -ENODEV; }
    > static inline int qcom_scm_io_writel(phys_addr_t addr, unsigned int val) { return -ENODEV; }
    > static inline int qcom_scm_io_readl_atomic(phys_addr_t addr, unsigned int *val) { return -ENODEV; }
    > --
    > QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
    > of Code Aurora Forum, hosted by The Linux Foundation
    >

    \
     
     \ /
      Last update: 2019-03-25 22:10    [W:2.678 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site