lkml.org 
[lkml]   [2019]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''
From
Date
On 2019/3/25 10:31, Kuninori Morimoto wrote:
>
> Hi
>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk':
>> sound/soc/generic/simple-card-utils.c:164:18: warning:
>> parameter 'dai_name' set but not used [-Wunused-but-set-parameter]
>>
>> It's not used since commit 0580dde59438 ("ASoC: simple-card-utils: add
>> asoc_simple_debug_info()"), so can be removed.
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>
> I think dai_name parameter itself is no longer needed for this function,
> but, it will be removed if all driver switched to modern dai_link style.
> So, it is not a big deal.
>
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Thanks, yes, this just a code cleanup.

>
> Best regards
> ---
> Kuninori Morimoto
>
> .
>

\
 
 \ /
  Last update: 2019-03-25 04:04    [W:0.064 / U:11.916 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site