lkml.org 
[lkml]   [2019]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2] dccp: Fix memleak in __feat_register_sp
From
Date

On 2019/3/25 8:12, David Miller wrote:
> From: Yue Haibing <yuehaibing@huawei.com>
> Date: Fri, 22 Mar 2019 21:43:48 +0800
>
>> From: YueHaibing <yuehaibing@huawei.com>
>>
>> If dccp_feat_push_change fails, we forget free the mem
>> which is alloced by kmemdup in dccp_feat_clone_sp_val.
>>
>> Reported-by: Hulk Robot <hulkci@huawei.com>
>> Fixes: e8ef967a54f4 ("dccp: Registration routines for changing feature values")
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
>> ---
>> v2: kfree 'val --> 'fval'
>
> Don't submit any patches for at least 2 days, I am getting really tired of
> changes you don't even COMPILE TEST:
>
> CC [M] net/dccp/feat.o
> net/dccp/feat.c: In function ‘__feat_register_sp’:
> net/dccp/feat.c:742:13: error: invalid type argument of ‘->’ (have ‘dccp_feat_val’ {aka ‘union <anonymous>’})
> kfree(fval->sp.vec);
>

I'm very sorry for this, will self-reflection.

^~
>

\
 
 \ /
  Last update: 2019-03-25 03:52    [W:0.060 / U:0.144 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site