lkml.org 
[lkml]   [2019]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH] media: tuners: fix a missing check for regmap_write_bits
Date
regmap_write_bits could fail and thus deserves a check.

The fix returns its error code upstream in case it fails.

Signed-off-by: Kangjie Lu <kjlu@umn.edu>
---
drivers/media/tuners/tda18250.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c
index 20d10ef45ab6..36ede1b02d23 100644
--- a/drivers/media/tuners/tda18250.c
+++ b/drivers/media/tuners/tda18250.c
@@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe)

/* charge pump */
ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]);
+ if (ret)
+ goto err;

return 0;
err:
--
2.17.1
\
 
 \ /
  Last update: 2019-03-25 00:22    [W:0.079 / U:24.408 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site