Messages in this thread | | | Date | Sun, 24 Mar 2019 16:34:36 +0000 | From | Jonathan Cameron <> | Subject | Re: [PATCH v5 1/2] staging: iio: ad5933: change attributes to match ABI |
| |
On Thu, 21 Mar 2019 15:42:13 -0300 Marcelo Schmitt <marcelo.schmitt1@gmail.com> wrote:
> Change device attributes' names to match ABI documentation. Names were > chosen such that they tend to be similar to existing ABI so it should > be easier to standardize them when necessary. > > Signed-off-by: Marcelo Schmitt <marcelo.schmitt1@gmail.com> > --- Change log here.
Anyhow, I looked back so fairly obviously what changed.
Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it.
Thanks,
Jonathan
> .../staging/iio/impedance-analyzer/ad5933.c | 24 +++++++++---------- > 1 file changed, 12 insertions(+), 12 deletions(-) > > diff --git a/drivers/staging/iio/impedance-analyzer/ad5933.c b/drivers/staging/iio/impedance-analyzer/ad5933.c > index d75bdfbf93de..2b0f8f899e3f 100644 > --- a/drivers/staging/iio/impedance-analyzer/ad5933.c > +++ b/drivers/staging/iio/impedance-analyzer/ad5933.c > @@ -315,12 +315,12 @@ static ssize_t ad5933_store_frequency(struct device *dev, > return ret ? ret : len; > } > > -static IIO_DEVICE_ATTR(out_voltage0_freq_start, 0644, > +static IIO_DEVICE_ATTR(out_altvoltage0_frequency_start, 0644, > ad5933_show_frequency, > ad5933_store_frequency, > AD5933_REG_FREQ_START); > > -static IIO_DEVICE_ATTR(out_voltage0_freq_increment, 0644, > +static IIO_DEVICE_ATTR(out_altvoltage0_frequency_increment, 0644, > ad5933_show_frequency, > ad5933_store_frequency, > AD5933_REG_FREQ_INC); > @@ -443,12 +443,12 @@ static ssize_t ad5933_store(struct device *dev, > return ret ? ret : len; > } > > -static IIO_DEVICE_ATTR(out_voltage0_scale, 0644, > +static IIO_DEVICE_ATTR(out_altvoltage0_raw, 0644, > ad5933_show, > ad5933_store, > AD5933_OUT_RANGE); > > -static IIO_DEVICE_ATTR(out_voltage0_scale_available, 0444, > +static IIO_DEVICE_ATTR(out_altvoltage0_scale_available, 0444, > ad5933_show, > NULL, > AD5933_OUT_RANGE_AVAIL); > @@ -463,12 +463,12 @@ static IIO_DEVICE_ATTR(in_voltage0_scale_available, 0444, > NULL, > AD5933_IN_PGA_GAIN_AVAIL); > > -static IIO_DEVICE_ATTR(out_voltage0_freq_points, 0644, > +static IIO_DEVICE_ATTR(out_altvoltage0_frequency_points, 0644, > ad5933_show, > ad5933_store, > AD5933_FREQ_POINTS); > > -static IIO_DEVICE_ATTR(out_voltage0_settling_cycles, 0644, > +static IIO_DEVICE_ATTR(out_altvoltage0_settling_cycles, 0644, > ad5933_show, > ad5933_store, > AD5933_OUT_SETTLING_CYCLES); > @@ -480,12 +480,12 @@ static IIO_DEVICE_ATTR(out_voltage0_settling_cycles, 0644, > * don't create dedicated sysfs channel attributes for out0 and in0. > */ > static struct attribute *ad5933_attributes[] = { > - &iio_dev_attr_out_voltage0_scale.dev_attr.attr, > - &iio_dev_attr_out_voltage0_scale_available.dev_attr.attr, > - &iio_dev_attr_out_voltage0_freq_start.dev_attr.attr, > - &iio_dev_attr_out_voltage0_freq_increment.dev_attr.attr, > - &iio_dev_attr_out_voltage0_freq_points.dev_attr.attr, > - &iio_dev_attr_out_voltage0_settling_cycles.dev_attr.attr, > + &iio_dev_attr_out_altvoltage0_raw.dev_attr.attr, > + &iio_dev_attr_out_altvoltage0_scale_available.dev_attr.attr, > + &iio_dev_attr_out_altvoltage0_frequency_start.dev_attr.attr, > + &iio_dev_attr_out_altvoltage0_frequency_increment.dev_attr.attr, > + &iio_dev_attr_out_altvoltage0_frequency_points.dev_attr.attr, > + &iio_dev_attr_out_altvoltage0_settling_cycles.dev_attr.attr, > &iio_dev_attr_in_voltage0_scale.dev_attr.attr, > &iio_dev_attr_in_voltage0_scale_available.dev_attr.attr, > NULL
| |