lkml.org 
[lkml]   [2019]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] tty: 8250: fix a missing check for pci_ioremap_bar
On Sun, Mar 24, 2019 at 2:05 PM Andy Shevchenko
<andy.shevchenko@gmail.com> wrote:
> On Sun, Mar 24, 2019 at 12:55 AM Aditya Pakki <pakki001@umn.edu> wrote:
> >
> > pci_ioremap_bar could fail. The fix captures the failure and
> > pass an error code upstream. This can avoid potential NULL
> > pointer dereferences in the future.
> >
>
> NAK.
> This will break non-DMA case.

> > @@ -172,12 +172,14 @@ static void qrk_serial_setup_dma(struct lpss8250 *lpss, struct uart_port *port)

Just to clarify, what you need is simple

void __iomem *regs;

chip->pdata = ... //move it here for better looking code
chip->irq = ...
chip->regs = pci_ioremap_bar(...);
if (!chip->regs)
return;

and thank you for pointing to this.

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-03-24 13:26    [W:0.040 / U:0.296 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site