lkml.org 
[lkml]   [2019]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] iio: st_accel: remove unnecessary comparison of unsigned integer with < 0
On Mon, 18 Mar 2019 12:33:02 -0500
"Gustavo A. R. Silva" <gustavo@embeddedor.com> wrote:

> There is no need to compare *val* with < 0 because such comparison
> of an unsigned value is always false.
>
> Fix this by removing such comparison.
>
> Addresses-Coverity-ID: 1443919 ("Unsigned compared against 0")
> Fixes: f38ab20b749d ("iio: st_accel: use ACPI orientation data")
> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Thanks,

Colin King got there first and I have a patch fixing this queued up.

Jonathan

> ---
> drivers/iio/accel/st_accel_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/accel/st_accel_core.c b/drivers/iio/accel/st_accel_core.c
> index a3c0916479fa..9930edf423bf 100644
> --- a/drivers/iio/accel/st_accel_core.c
> +++ b/drivers/iio/accel/st_accel_core.c
> @@ -992,7 +992,7 @@ static int apply_acpi_orientation(struct iio_dev *indio_dev,
> goto out;
>
> val = elements[i].integer.value;
> - if (val < 0 || val > 2)
> + if (val > 2)
> goto out;
>
> /* Avoiding full matrix multiplication, we simply reorder the

\
 
 \ /
  Last update: 2019-03-24 13:26    [W:0.036 / U:4.172 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site