lkml.org 
[lkml]   [2019]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] infiniband: cxgb4: fix a potential NULL pointer dereference
From
Date
On 3/22/19 7:37 PM, Kangjie Lu wrote:
>> On Mar 8, 2019, at 11:19 PM, Kangjie Lu <kjlu@umn.edu> wrote:
>> get_skb may fail and return NULL. The fix returns "ENOMEM"
>> when it fails to avoid NULL dereference.
>>
>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>> ---
>> drivers/infiniband/hw/cxgb4/cm.c | 3 +++
>> 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
>> index 8221813219e5..502a54d57e2c 100644
>> --- a/drivers/infiniband/hw/cxgb4/cm.c
>> +++ b/drivers/infiniband/hw/cxgb4/cm.c
>> @@ -1919,6 +1919,9 @@ static int send_fw_act_open_req(struct c4iw_ep *ep, unsigned int atid)
>> int win;
>>
>> skb = get_skb(NULL, sizeof(*req), GFP_KERNEL);
>> + if (!skb)
>> + return -ENOMEM;
>> +
>
> Can someone review this patch? Thanks.

Hi Kangjie,

Please change the patch description to the imperative mood (see also
https://git.kernel.org/pub/scm/git/git.git/tree/Documentation/SubmittingPatches).
A good way to invite feedback is to add a relevant Cc-list to a patch.
The output of scripts/get_maintainer.pl can be a good start.

Bart.

\
 
 \ /
  Last update: 2019-03-24 00:27    [W:0.068 / U:42.464 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site