lkml.org 
[lkml]   [2019]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers
Date
> -----Original Message-----
> From: linux-edac-owner@vger.kernel.org <linux-edac-owner@vger.kernel.org> On Behalf Of Borislav Petkov
> Sent: Saturday, March 23, 2019 7:16 AM
> To: Ghannam, Yazen <Yazen.Ghannam@amd.com>
> Cc: linux-edac@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH v3 3/6] EDAC/amd64: Support more than two Unified Memory Controllers
>
> On Thu, Feb 28, 2019 at 03:36:10PM +0000, Ghannam, Yazen wrote:
> > diff --git a/drivers/edac/amd64_edac.h b/drivers/edac/amd64_edac.h
> > index de8dbb0b42b5..40e63cea2d81 100644
> > --- a/drivers/edac/amd64_edac.h
> > +++ b/drivers/edac/amd64_edac.h
> > @@ -274,7 +274,11 @@
> >
> > #define UMC_SDP_INIT BIT(31)
> >
> > -#define NUM_UMCS 2
> > +/*
> > + * Number of Unified Memory Controllers
> > + * Set during driver init based on family/model.
> > + */
> > +static u8 num_umcs;
>
> Please don't do silly things like that:
>
> In file included from drivers/edac/amd64_edac_inj.c:2:0:
> drivers/edac/amd64_edac.h:279:11: warning: ‘num_umcs’ defined but not used [-Wunused-variable]
> static u8 num_umcs;
> ^~~~~~~~
>
> I fixed it up now.
>

Thanks. Sorry I missed that.

-Yazen
\
 
 \ /
  Last update: 2019-03-23 18:22    [W:0.066 / U:1.976 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site