lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 105/280] nfp: bpf: fix code-gen bug on BPF_ALU | BPF_XOR | BPF_K
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    [ Upstream commit 71c190249f0ced5b26377ea6bf829ab3af77a40c ]

    The intended optimization should be A ^ 0 = A, not A ^ -1 = A.

    Fixes: cd7df56ed3e6 ("nfp: add BPF to NFP code translator")
    Reviewed-by: Jakub Kicinski <jakub.kicinski@netronome.com>
    Signed-off-by: Jiong Wang <jiong.wang@netronome.com>
    Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/net/ethernet/netronome/nfp/bpf/jit.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/drivers/net/ethernet/netronome/nfp/bpf/jit.c b/drivers/net/ethernet/netronome/nfp/bpf/jit.c
    index eff57f7d056a..0a934296ea53 100644
    --- a/drivers/net/ethernet/netronome/nfp/bpf/jit.c
    +++ b/drivers/net/ethernet/netronome/nfp/bpf/jit.c
    @@ -2306,7 +2306,7 @@ static int xor_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)

    static int xor_imm(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)
    {
    - return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !~meta->insn.imm);
    + return wrp_alu32_imm(nfp_prog, meta, ALU_OP_XOR, !meta->insn.imm);
    }

    static int and_reg(struct nfp_prog *nfp_prog, struct nfp_insn_meta *meta)
    --
    2.19.1


    \
     
     \ /
      Last update: 2019-03-22 13:44    [W:4.432 / U:0.172 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site