[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Patch in this message
Subject[PATCH 5.0 113/238] nvmem: core: dont check the return value of notifier chain call
5.0-stable review patch.  If anyone has any objections, please let me know.


From: Bartosz Golaszewski <>

commit f4853e1c321edb48af229ad5ac85076790d34968 upstream.

blocking_notifier_call_chain() returns the value returned by the last
registered callback. A positive return value doesn't indicate an error
and an nvmem device should correctly register irrespective of any
notifier callback failures. Drop the retval check.

Fixes: bee1138bea15 ("nvmem: add a notifier chain")
Signed-off-by: Bartosz Golaszewski <>
Acked-by: Srinivas Kandagatla <>
Signed-off-by: Greg Kroah-Hartman <>

drivers/nvmem/core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

--- a/drivers/nvmem/core.c
+++ b/drivers/nvmem/core.c
@@ -686,9 +686,7 @@ struct nvmem_device *nvmem_register(cons
if (rval)
goto err_remove_cells;

- rval = blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);
- if (rval)
- goto err_remove_cells;
+ blocking_notifier_call_chain(&nvmem_notifier, NVMEM_ADD, nvmem);

return nvmem;

 \ /
  Last update: 2019-03-22 13:32    [W:0.546 / U:26.576 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site