lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 114/238] device property: Fix the length used in PROPERTY_ENTRY_STRING()
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Heikki Krogerus <heikki.krogerus@linux.intel.com>

    commit 2b6e492467c78183bb629bb0a100ea3509b615a5 upstream.

    With string type property entries we need to use
    sizeof(const char *) instead of the number of characters as
    the length of the entry.

    If the string was shorter then sizeof(const char *),
    attempts to read it would have failed with -EOVERFLOW. The
    problem has been hidden because all build-in string
    properties have had a string longer then 8 characters until
    now.

    Fixes: a85f42047533 ("device property: helper macros for property entry creation")
    Cc: 4.5+ <stable@vger.kernel.org> # 4.5+
    Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
    Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
    Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    include/linux/property.h | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/include/linux/property.h
    +++ b/include/linux/property.h
    @@ -258,7 +258,7 @@ struct property_entry {
    #define PROPERTY_ENTRY_STRING(_name_, _val_) \
    (struct property_entry) { \
    .name = _name_, \
    - .length = sizeof(_val_), \
    + .length = sizeof(const char *), \
    .type = DEV_PROP_STRING, \
    { .value = { .str = _val_ } }, \
    }

    \
     
     \ /
      Last update: 2019-03-22 13:32    [W:4.188 / U:0.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site