lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.0 122/238] ext4: add mask of ext4 flags to swap
    Date
    5.0-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: yangerkun <yangerkun@huawei.com>

    commit abdc644e8cbac2e9b19763680e5a7cf9bab2bee7 upstream.

    The reason is that while swapping two inode, we swap the flags too.
    Some flags such as EXT4_JOURNAL_DATA_FL can really confuse the things
    since we're not resetting the address operations structure. The
    simplest way to keep things sane is to restrict the flags that can be
    swapped.

    Signed-off-by: yangerkun <yangerkun@huawei.com>
    Signed-off-by: Theodore Ts'o <tytso@mit.edu>
    Cc: stable@vger.kernel.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    fs/ext4/ext4.h | 3 +++
    fs/ext4/ioctl.c | 6 +++++-
    2 files changed, 8 insertions(+), 1 deletion(-)

    --- a/fs/ext4/ext4.h
    +++ b/fs/ext4/ext4.h
    @@ -426,6 +426,9 @@ struct flex_groups {
    /* Flags that are appropriate for non-directories/regular files. */
    #define EXT4_OTHER_FLMASK (EXT4_NODUMP_FL | EXT4_NOATIME_FL)

    +/* The only flags that should be swapped */
    +#define EXT4_FL_SHOULD_SWAP (EXT4_HUGE_FILE_FL | EXT4_EXTENTS_FL)
    +
    /* Mask out flags that are inappropriate for the given type of inode. */
    static inline __u32 ext4_mask_flags(umode_t mode, __u32 flags)
    {
    --- a/fs/ext4/ioctl.c
    +++ b/fs/ext4/ioctl.c
    @@ -63,6 +63,7 @@ static void swap_inode_data(struct inode
    loff_t isize;
    struct ext4_inode_info *ei1;
    struct ext4_inode_info *ei2;
    + unsigned long tmp;

    ei1 = EXT4_I(inode1);
    ei2 = EXT4_I(inode2);
    @@ -72,7 +73,10 @@ static void swap_inode_data(struct inode
    swap(inode1->i_mtime, inode2->i_mtime);

    memswap(ei1->i_data, ei2->i_data, sizeof(ei1->i_data));
    - swap(ei1->i_flags, ei2->i_flags);
    + tmp = ei1->i_flags & EXT4_FL_SHOULD_SWAP;
    + ei1->i_flags = (ei2->i_flags & EXT4_FL_SHOULD_SWAP) |
    + (ei1->i_flags & ~EXT4_FL_SHOULD_SWAP);
    + ei2->i_flags = tmp | (ei2->i_flags & ~EXT4_FL_SHOULD_SWAP);
    swap(ei1->i_disksize, ei2->i_disksize);
    ext4_es_remove_extent(inode1, 0, EXT_MAX_BLOCKS);
    ext4_es_remove_extent(inode2, 0, EXT_MAX_BLOCKS);

    \
     
     \ /
      Last update: 2019-03-22 13:22    [W:2.138 / U:0.000 seconds]
    ©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site