lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 167/280] m68k: Add -ffreestanding to CFLAGS
    Date
    4.19-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Finn Thain <fthain@telegraphics.com.au>

    commit 28713169d879b67be2ef2f84dcf54905de238294 upstream.

    This patch fixes a build failure when using GCC 8.1:

    /usr/bin/ld: block/partitions/ldm.o: in function `ldm_parse_tocblock':
    block/partitions/ldm.c:153: undefined reference to `strcmp'

    This is caused by a new optimization which effectively replaces a
    strncmp() call with a strcmp() call. This affects a number of strncmp()
    call sites in the kernel.

    The entire class of optimizations is avoided with -fno-builtin, which
    gets enabled by -ffreestanding. This may avoid possible future build
    failures in case new optimizations appear in future compilers.

    I haven't done any performance measurements with this patch but I did
    count the function calls in a defconfig build. For example, there are now
    23 more sprintf() calls and 39 fewer strcpy() calls. The effect on the
    other libc functions is smaller.

    If this harms performance we can tackle that regression by optimizing
    the call sites, ideally using semantic patches. That way, clang and ICC
    builds might benfit too.

    Cc: stable@vger.kernel.org
    Reference: https://marc.info/?l=linux-m68k&m=154514816222244&w=2
    Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
    Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

    ---
    arch/m68k/Makefile | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    --- a/arch/m68k/Makefile
    +++ b/arch/m68k/Makefile
    @@ -58,7 +58,10 @@ cpuflags-$(CONFIG_M5206e) := $(call cc-o
    cpuflags-$(CONFIG_M5206) := $(call cc-option,-mcpu=5206,-m5200)

    KBUILD_AFLAGS += $(cpuflags-y)
    -KBUILD_CFLAGS += $(cpuflags-y) -pipe
    +KBUILD_CFLAGS += $(cpuflags-y)
    +
    +KBUILD_CFLAGS += -pipe -ffreestanding
    +
    ifdef CONFIG_MMU
    # without -fno-strength-reduce the 53c7xx.c driver fails ;-(
    KBUILD_CFLAGS += -fno-strength-reduce -ffixed-a2

    \
     
     \ /
      Last update: 2019-03-22 13:06    [W:2.162 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site