Messages in this thread | | | From | Ondrej Mosnacek <> | Date | Fri, 22 Mar 2019 18:45:59 +0100 | Subject | Re: [PATCH -next] selinux: Make selinux_kernfs_init_security static |
| |
On Fri, Mar 22, 2019 at 3:04 PM Yue Haibing <yuehaibing@huawei.com> wrote: > From: YueHaibing <yuehaibing@huawei.com> > > Fix sparse warning: > > security/selinux/hooks.c:3389:5: warning: > symbol 'selinux_kernfs_init_security' was not declared. Should it be static? > > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Yup, another trivial mistake on my part...
Acked-by: Ondrej Mosnacek <omosnace@redhat.com>
Thanks for catching that!
> --- > security/selinux/hooks.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/security/selinux/hooks.c b/security/selinux/hooks.c > index ab4b049..b6e6152 100644 > --- a/security/selinux/hooks.c > +++ b/security/selinux/hooks.c > @@ -3386,8 +3386,8 @@ static int selinux_inode_copy_up_xattr(const char *name) > > /* kernfs node operations */ > > -int selinux_kernfs_init_security(struct kernfs_node *kn_dir, > - struct kernfs_node *kn) > +static int selinux_kernfs_init_security(struct kernfs_node *kn_dir, > + struct kernfs_node *kn) > { > const struct task_security_struct *tsec = current_security(); > u32 parent_sid, newsid, clen; > -- > 2.7.0
-- Ondrej Mosnacek <omosnace at redhat dot com> Software Engineer, Security Technologies Red Hat, Inc.
| |