lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[BACKPORT 4.4.y 14/25] kbuild: setlocalversion: print error to STDERR
    Date
    From: Wolfram Sang <wsa@the-dreams.de>

    I tried to use 'make O=...' from an unclean source tree. This triggered
    the error path of setlocalversion. But by printing to STDOUT, it created
    a broken localversion which then caused another (unrelated) error:

    "4.7.0-rc2Error: kernelrelease not valid - run make prepare to update it" exceeds 64 characters

    After printing to STDERR, the true build error gets displayed later:

    /home/wsa/Kernel/linux is not clean, please run 'make mrproper'
    in the '/home/wsa/Kernel/linux' directory.

    Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
    Signed-off-by: Michal Marek <mmarek@suse.com>
    (cherry picked from commit 78283edf2c01c38eb840a3de5ffd18fe2992ab64)
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    scripts/setlocalversion | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/scripts/setlocalversion b/scripts/setlocalversion
    index 63d91e22ed7c..966dd3924ea9 100755
    --- a/scripts/setlocalversion
    +++ b/scripts/setlocalversion
    @@ -143,7 +143,7 @@ fi
    if test -e include/config/auto.conf; then
    . include/config/auto.conf
    else
    - echo "Error: kernelrelease not valid - run 'make prepare' to update it"
    + echo "Error: kernelrelease not valid - run 'make prepare' to update it" >&2
    exit 1
    fi

    --
    2.20.0
    \
     
     \ /
      Last update: 2019-03-22 16:49    [W:3.781 / U:0.252 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site