lkml.org 
[lkml]   [2019]   [Mar]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[BACKPORT 4.4.y 15/25] usb: gadget: composite: fix dereference after null check coverify warning
    Date
    From: Peter Chen <peter.chen@nxp.com>

    cdev->config is checked for null pointer at above code, so cdev->config
    might be null, fix it by adding null pointer check.

    Signed-off-by: Peter Chen <peter.chen@nxp.com>
    Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
    (cherry picked from commit c526c62d565ea5a5bba9433f28756079734f430d)
    Signed-off-by: Arnd Bergmann <arnd@arndb.de>
    ---
    drivers/usb/gadget/composite.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/usb/gadget/composite.c b/drivers/usb/gadget/composite.c
    index 58f5fbdb6959..8bf54477f472 100644
    --- a/drivers/usb/gadget/composite.c
    +++ b/drivers/usb/gadget/composite.c
    @@ -1819,6 +1819,8 @@ unknown:
    break;

    case USB_RECIP_ENDPOINT:
    + if (!cdev->config)
    + break;
    endp = ((w_index & 0x80) >> 3) | (w_index & 0x0f);
    list_for_each_entry(f, &cdev->config->functions, list) {
    if (test_bit(endp, f->endpoints))
    --
    2.20.0
    \
     
     \ /
      Last update: 2019-03-22 16:49    [W:4.669 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site