Messages in this thread | | | Date | Thu, 21 Mar 2019 22:01:33 +0530 | From | "Bharadiya,Pankaj" <> | Subject | Re: [alsa-devel] [PATCH] ASoC: dapm: Fix NULL pointer dereference in snd_soc_dapm_new_dai |
| |
On Thu, Mar 21, 2019 at 02:09:48PM +0000, Mark Brown wrote: > On Thu, Mar 21, 2019 at 08:59:55AM -0500, Pierre-Louis Bossart wrote: > > On 3/21/19 7:31 AM, Mark Brown wrote: > > > On Thu, Mar 21, 2019 at 03:41:25PM +0530, Pankaj Bharadiya wrote: > > > > This is very non-obvious - it's not at all clear why we'd need the text > > > to free controls. If there is an issue here it seems like it'd be > > > better to make sure that snd_soc_dapm_free_kcontrol() can cope with that > > > being NULL, that will be clearer and also avoid potential issues with > > > other callers. > > > I believe the issue is real, but you need to look at the entire code to figure it out > > Yeah, I'm fairly sure there's an actual issue here - it's just that the > fix is obscure and feels fragile.
Will fix it in snd_soc_dapm_free_kcontrol() and submit a new patch..
Thanks, Pankaj
| |