lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [RFC PATCH 05/20] drm: Replace instances of drm_format_info by drm_get_format_info
    From
    Date
    Hi,

    Le mardi 19 mars 2019 à 22:57 +0100, Maxime Ripard a écrit :
    > drm_get_format_info directly calls into drm_format_info, but takes directly
    > a struct drm_mode_fb_cmd2 pointer, instead of the fourcc directly. It's
    > shorter to not dereference it, and we can customise the behaviour at the
    > driver level if we want to, so let's switch to it where it makes sense.
    >
    > Signed-off-by: Maxime Ripard <maxime.ripard@bootlin.com>

    Makes good sense to me!

    Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>

    Cheers,

    Paul

    > ---
    > drivers/gpu/drm/gma500/framebuffer.c | 2 +-
    > drivers/gpu/drm/omapdrm/omap_fb.c | 2 +-
    > 2 files changed, 2 insertions(+), 2 deletions(-)
    >
    > diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
    > index c934b3df1f81..46f0078f7a91 100644
    > --- a/drivers/gpu/drm/gma500/framebuffer.c
    > +++ b/drivers/gpu/drm/gma500/framebuffer.c
    > @@ -232,7 +232,7 @@ static int psb_framebuffer_init(struct drm_device *dev,
    > * Reject unknown formats, YUV formats, and formats with more than
    > * 4 bytes per pixel.
    > */
    > - info = drm_format_info(mode_cmd->pixel_format);
    > + info = drm_get_format_info(dev, mode_cmd);
    > if (!info || !info->depth || info->cpp[0] > 4)
    > return -EINVAL;
    >
    > diff --git a/drivers/gpu/drm/omapdrm/omap_fb.c b/drivers/gpu/drm/omapdrm/omap_fb.c
    > index cfb641363a32..6557b2d6e16e 100644
    > --- a/drivers/gpu/drm/omapdrm/omap_fb.c
    > +++ b/drivers/gpu/drm/omapdrm/omap_fb.c
    > @@ -339,7 +339,7 @@ struct drm_framebuffer *omap_framebuffer_init(struct drm_device *dev,
    > dev, mode_cmd, mode_cmd->width, mode_cmd->height,
    > (char *)&mode_cmd->pixel_format);
    >
    > - format = drm_format_info(mode_cmd->pixel_format);
    > + format = drm_get_format_info(dev, mode_cmd);
    >
    > for (i = 0; i < ARRAY_SIZE(formats); i++) {
    > if (formats[i] == mode_cmd->pixel_format)
    --
    Paul Kocialkowski, Bootlin
    Embedded Linux and kernel engineering
    https://bootlin.com

    \
     
     \ /
      Last update: 2019-03-20 15:29    [W:2.201 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site