lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] thunderbolt: xdomain: Fix to check return value of kmemdup
On Mon, Mar 18, 2019 at 05:55:08PM -0500, Aditya Pakki wrote:
> @@ -1417,8 +1420,7 @@ bool tb_xdomain_handle_request(struct tb *tb, enum tb_cfg_pkg_type type,
> */
> if (uuid_equal(&hdr->uuid, &tb_xdp_uuid)) {
> if (type == TB_CFG_PKG_XDOMAIN_REQ) {
> - tb_xdp_schedule_request(tb, hdr, size);
> - return true;
> + return tb_xdp_schedule_request(tb, hdr, size);

Please remove parens as well that there is only a single statement
following the if-block.

Otherwise looks fine.

\
 
 \ /
  Last update: 2019-03-20 11:51    [W:0.046 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site