lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH -next] phy: tegra: xusb: Make two functions static
On Tue, Mar 19, 2019 at 11:32:19PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warning:
>
> drivers/phy/tegra/xusb-tegra186.c:250:6: warning: symbol 'tegra_phy_xusb_utmi_pad_power_on' was not declared. Should it be static?
> drivers/phy/tegra/xusb-tegra186.c:281:6: warning: symbol 'tegra_phy_xusb_utmi_pad_power_down' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/phy/tegra/xusb-tegra186.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

Sigh... I evidently need to improve my build scripts.

Acked-by: Thierry Reding <treding@nvidia.com>

> diff --git a/drivers/phy/tegra/xusb-tegra186.c b/drivers/phy/tegra/xusb-tegra186.c
> index 11ad6e4..7a308b4 100644
> --- a/drivers/phy/tegra/xusb-tegra186.c
> +++ b/drivers/phy/tegra/xusb-tegra186.c
> @@ -247,7 +247,7 @@ static void tegra186_utmi_bias_pad_power_off(struct tegra_xusb_padctl *padctl)
> mutex_unlock(&padctl->lock);
> }
>
> -void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
> +static void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
> {
> struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
> struct tegra_xusb_padctl *padctl = lane->pad->padctl;
> @@ -278,7 +278,7 @@ void tegra_phy_xusb_utmi_pad_power_on(struct phy *phy)
> padctl_writel(padctl, value, XUSB_PADCTL_USB2_OTG_PADX_CTL1(index));
> }
>
> -void tegra_phy_xusb_utmi_pad_power_down(struct phy *phy)
> +static void tegra_phy_xusb_utmi_pad_power_down(struct phy *phy)
> {
> struct tegra_xusb_lane *lane = phy_get_drvdata(phy);
> struct tegra_xusb_padctl *padctl = lane->pad->padctl;
> --
> 2.7.4
>
>
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2019-03-20 09:43    [W:0.034 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site