lkml.org 
[lkml]   [2019]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] watchdog: alim7101: Mark expected switch fall-through
    From
    Date


    On 3/20/19 7:12 PM, Guenter Roeck wrote:
    > On 3/20/19 11:16 AM, Gustavo A. R. Silva wrote:
    >> In preparation to enabling -Wimplicit-fallthrough, mark switch
    >> cases where we are expecting to fall through.
    >>
    >> This patch fixes the following warning:
    >>
    >> drivers/watchdog/alim7101_wdt.c: In function ‘fop_ioctl’:
    >> drivers/watchdog/alim7101_wdt.c:279:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
    >>     wdt_keepalive();
    >>     ^~~~~~~~~~~~~~~
    >> drivers/watchdog/alim7101_wdt.c:282:2: note: here
    >>    case WDIOC_GETTIMEOUT:
    >>    ^~~~
    >>
    >> Notice that, in this particular case, the /* Fall through */
    >> comment is placed at the very bottom of the case statement,
    >> which is what GCC is expecting to find.
    >>
    >> Warning level 3 was used: -Wimplicit-fallthrough=3
    >>
    >> This patch is part of the ongoing efforts to enabling
    >> -Wimplicit-fallthrough.
    >>
    >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
    >
    > Reviewed-by: Guenter Roeck <linux@roeck-us.net>
    >

    Thanks, Guenter. :)

    --
    Gustavo

    >> ---
    >>   drivers/watchdog/alim7101_wdt.c | 2 +-
    >>   1 file changed, 1 insertion(+), 1 deletion(-)
    >>
    >> diff --git a/drivers/watchdog/alim7101_wdt.c b/drivers/watchdog/alim7101_wdt.c
    >> index 12f7ea62dddd..f5ada07e9202 100644
    >> --- a/drivers/watchdog/alim7101_wdt.c
    >> +++ b/drivers/watchdog/alim7101_wdt.c
    >> @@ -277,8 +277,8 @@ static long fop_ioctl(struct file *file, unsigned int cmd, unsigned long arg)
    >>               return -EINVAL;
    >>           timeout = new_timeout;
    >>           wdt_keepalive();
    >> -        /* Fall through */
    >>       }
    >> +        /* Fall through */
    >>       case WDIOC_GETTIMEOUT:
    >>           return put_user(timeout, p);
    >>       default:
    >>
    >

    \
     
     \ /
      Last update: 2019-03-21 01:15    [W:3.074 / U:0.128 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site