Messages in this thread | | | Subject | Re: [PATCH] x86: uv: Fix potential NULL pointer dereference of kmalloc_node | From | Joe Perches <> | Date | Sat, 02 Mar 2019 13:12:49 -0800 |
| |
On Sat, 2019-03-02 at 15:09 -0600, Aditya Pakki wrote: > kmalloc_node might fail to allocate memory for thp field. This fix > attempts to avoid a potential NULL pointer dereference.
right
> diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c [] > @@ -2011,6 +2011,9 @@ static void make_per_cpu_thp(struct bau_control *smaster) > size_t hpsz = sizeof(struct hub_and_pnode) * num_possible_cpus(); > > smaster->thp = kmalloc_node(hpsz, GFP_KERNEL, smaster->osnode); > + if (!smaster->thp) > + return; > + > memset(smaster->thp, 0, hpsz);
Could use kzalloc_node as well
| |