[lkml]   [2019]   [Mar]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH] mtd: rawnand: ams-delta: Drop board specific partition info
On Tue, Mar 19, 2019 at 11:37:18PM +0100, Janusz Krzysztofik wrote:
> After recent modifications, only a hardcoded partition info makes
> the driver device specific. Other than that, the driver uses GPIO
> exclusively and can be used on any hardware.
> Drop the partition info and use MTD partition parser with default
> list of partition types instead.
> Amstrad Delta users should append the followig partition info to their
Should be "following".

> kernel command line, possibly by embedding it in CONFIG_CMDLINE:
> mtdparts=ams-delta-nand:3584k(Kernel),256k(u-boot),256k(u-boot_params),\
> 256k(Amstrad_LDR),27m(File_system),768k(PBL_reserved). For their
> convenience, select CONFIG_MTD_CMDLINE_PARTS symbol from that board
> Kconfig automatically if this NAND driver is also selected.
> Signed-off-by: Janusz Krzysztofik <>
> Cc: Tony Lindgren <>

Could we move the fixed partition setup to the board file
instead? Otherwise this kind of change is not really nice for the users,
as it will likely break existing setups. The default partition layout
should remain the same.


 \ /
  Last update: 2019-03-20 02:17    [W:0.124 / U:6.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site