Messages in this thread | | | Date | Sun, 17 Mar 2019 19:38:43 +0100 | From | Andrew Lunn <> | Subject | Re: [PATCH net] net: phy: Don't assume loopback is supported |
| |
On Fri, Mar 15, 2019 at 03:48:41PM -0700, Florian Fainelli wrote: > On 3/14/19 3:37 AM, Jose Abreu wrote: > > Some PHYs may not support loopback mode so we need to check if register > > is read-only. > > > > In that case it may be appropriate to have a specific PHY driver that > implements a set_loopback() method returning -EOPNOTSUPP instead of > changing the generic PHY implementation.
Hi Jose
Since Heiner says this is a mandatory feature, we should not really penalise conformant PHYs just because there is one broken PHY.
Please handle this in the PHY driver, by implementing the set_loopback call.
Andrew
| |