lkml.org 
[lkml]   [2019]   [Mar]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 3/3] auxdisplay: charlcd: make backlight initial state configurable
Date
Miguel Ojeda <miguel.ojeda.sandonis@gmail.com> writes:

> On Tue, Mar 12, 2019 at 4:48 PM Måns Rullgård <mans@mansr.com> wrote:
>>
>> The current code unconditionally flashes the light once. I though it
>> best to keep that behaviour as default, even if it's not seen as ideal.
>
> Sent into -next. If no one else says anything after a few days, I will
> send the series for -rc2.
>
> By the way, what about the other comment Andy mentioned? i.e.
> "defined(_OFF)" (in case you missed to answer it).

With a correct config, there should be no difference. If someone
managed to create a config without any of the alternatives selected,
a compiler error would result. I don't really have much of an opinion
on which behaviour is preferable in that situation.

--
Måns Rullgård

\
 
 \ /
  Last update: 2019-03-17 17:53    [W:0.037 / U:5.600 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site