lkml.org 
[lkml]   [2019]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 02/45] drivers: tty: serial: 8250_dw: use devm_ioremap_resource()
On Fri, Mar 15, 2019 at 12:41 AM Enrico Weigelt, metux IT consult
<info@metux.net> wrote:
>
> Instead of fetching out data from a struct resource for passing
> it to devm_ioremap(), directly use devm_ioremap_resource()

I don't see any advantage of this change.
See also below.

> --- a/drivers/tty/serial/8250/8250_dw.c
> +++ b/drivers/tty/serial/8250/8250_dw.c
> @@ -526,7 +526,7 @@ static int dw8250_probe(struct platform_device *pdev)
> p->set_ldisc = dw8250_set_ldisc;
> p->set_termios = dw8250_set_termios;
>
> - p->membase = devm_ioremap(dev, regs->start, resource_size(regs));
> + p->membase = devm_ioremap_resource(dev, regs);
> if (!p->membase)

And how did you test this? devm_ioremap_resource() returns error
pointer in case of error.

> return -ENOMEM;

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2019-03-15 10:05    [W:0.155 / U:5.288 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site