Messages in this thread |  | | Subject | RE: [RESEND PATCH] PM / devfreq: Fix static checker warning in try_then_request_governor | From | MyungJoo Ham <> | Date | Thu, 14 Mar 2019 16:47:34 +0900 |
| |
>The patch 23c7b54ca1cd: "PM / devfreq: Fix devfreq_add_device() when >drivers are built as modules." leads to the following static checker >warning: > > drivers/devfreq/devfreq.c:1043 governor_store() > warn: 'governor' can also be NULL > >The reason is that the try_then_request_governor() function returns both >error pointers and NULL. It should just return error pointers, so fix >this by returning a ERR_PTR to the error intead of returning NULL. > >Fixes: 23c7b54ca1cd ("PM / devfreq: Fix devfreq_add_device() when drivers are built as modules.") >Reported-by: Dan Carpenter <dan.carpenter@oracle.com> >Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> >Reviewed-by: Chanwoo Choi <cw00.choi@samsung.com> >--- >Hi, > >This is a resend of [1] as seems that got lost at some point and I just >noticed that was never merged. > >Thanks, > Enric
Acked-by: MyungJoo Ham <myungjoo.ham@samsung.com>
Thanks!
CHeers, MyungJoo
|  |