lkml.org 
[lkml]   [2019]   [Mar]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH] thunderbolt: property: fix a NULL pointer dereference
    Date
    In case kzalloc fails, the fix releases resources and returns
    -ENOMEM to avoid the NULL pointer dereference.

    Signed-off-by: Kangjie Lu <kjlu@umn.edu>
    ---
    drivers/thunderbolt/property.c | 5 +++++
    1 file changed, 5 insertions(+)

    diff --git a/drivers/thunderbolt/property.c b/drivers/thunderbolt/property.c
    index b2f0d6386cee..ee76449524a3 100644
    --- a/drivers/thunderbolt/property.c
    +++ b/drivers/thunderbolt/property.c
    @@ -548,6 +548,11 @@ int tb_property_add_data(struct tb_property_dir *parent, const char *key,

    property->length = size / 4;
    property->value.data = kzalloc(size, GFP_KERNEL);
    + if (!property->value.data) {
    + kfree(property);
    + return -ENOMEM;
    + }
    +
    memcpy(property->value.data, buf, buflen);

    list_add_tail(&property->list, &parent->properties);
    --
    2.17.1
    \
     
     \ /
      Last update: 2019-03-12 09:34    [W:4.400 / U:1.092 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site