Messages in this thread | | | From | Jagan Teki <> | Date | Mon, 11 Mar 2019 20:03:52 +0530 | Subject | Re: [PATCH v9 3/5] drm/sun4i: sun6i_mipi_dsi: Support vblk timing for 4-lane devices |
| |
On Mon, Mar 11, 2019 at 7:34 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > On Thu, Mar 07, 2019 at 09:33:38PM +0530, Jagan Teki wrote: > > On Mon, Mar 4, 2019 at 9:19 PM Maxime Ripard <maxime.ripard@bootlin.com> wrote: > > > > > > On Sun, Mar 03, 2019 at 11:05:25PM +0530, Jagan Teki wrote: > > > > Like other dsi setup timings, or hblk for that matter vblk would > > > > also require compute the timings based payload equation along with > > > > packet overhead. > > > > > > > > But, on the other hand vblk computation is also depends on device > > > > lane number. > > > > - for 4 lane devices, it is computed based on vtotal, packet overhead > > > > along with hblk value. > > > > - for others devices, it is simply 0 > > > > > > > > BSP code from BPI-M64-bsp is computing vblk as for 4-lane devices > > > > (from linux-sunxi > > > > drivers/video/sunxi/disp2/disp/de/lowlevel_sun50iw1/de_dsi.c) > > > > > > > > tmp = (ht*dsi_pixel_bits[format]/8)*vt-(4+dsi_hblk+2); > > > > dsi_vblk = (lane-tmp%lane); > > > > > > > > So, update the vblk timing calculation to support all type of > > > > devices. > > > > > > > > Tested on 2-lane, 4-lane MIPI-DSI LCD panels. > > > > > > You should be explaining which issue you faced, in which setup, what > > > were its symptoms and how that solution is fixing it. > > > > No, it is not a fix, didn't specify either. it is vblk timings support > > like others dsi timings. > > So it's not fixing anything, and this isn't a new feature > either. What's the point then?
You can consider a feature, as comments says it's vblk support for 4-lane devices which doesn't be 0. don't know why you are asking like a first time patch since it's commented before[1]
[1] https://patchwork.kernel.org/patch/10657543/
| |