lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] drm/bochs: Fix NULL dereference on atomic_disable helper
  Hi,

> > IIRC the drm code checks for the atomic_enable callback presence to
> > figure whenever it should take the atomic or legacy code paths.
>
> It should check for drm_driver->mode_config.funcs.atomic_commit for that,
> see drm_drv_uses_atomic_modeset(). Anything else should be a bug.
>
> Or do you mean the fallback to the old crtc helper prepare/commit
> callbacks?

Probably the later. There was some reason why I've left in the empty
bochs_crtc_atomic_enable() callback ...

cheers,
Gerd

\
 
 \ /
  Last update: 2019-03-11 14:39    [W:0.122 / U:0.084 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site