lkml.org 
[lkml]   [2019]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [LKP] [selftests/vm] a05ef00c97: kernel_selftests.vm.vmalloc_stability_smoke_test.fail
On Mon, 11 Mar 2019 10:20:06 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:

> On Mon, Mar 11, 2019 at 12:43 AM kernel test robot
> <rong.a.chen@intel.com> wrote:
> >
> > ./run_vmtests: line 217: ./test_vmalloc.sh: Permission denied
>
> I marked that script executable:
>
> 6bc3fe8e7e17 ("tools: mark 'test_vmalloc.sh' executable")
>
> although perhaps the better fix would have been to explicitly use the
> shell to start it in the 'run_vmtests' script instead?
>
> We have a lot of files that aren't marked executable, probably because
> they came in as (or were generated as) non-git patches. Often through
> Andrew's workflow.

Not only that. patch(1) doesn't set the x bit. So if someone
downloads and applies patch-5.0-rc1.xz (as we say to do in the
documentation), their kernel won't work correctly.

This happens fairly regularly and the fix is to replace

test_vmalloc.sh ...

with

/bin/sh test_vmalloc.sh ...


\
 
 \ /
  Last update: 2019-03-11 22:56    [W:0.033 / U:1.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site