lkml.org 
[lkml]   [2019]   [Mar]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH] drm/amdgpu/powerplay: Fix missing break in switch statement
    On Fri, Mar 1, 2019 at 4:51 PM Gustavo A. R. Silva
    <gustavo@embeddedor.com> wrote:
    >
    > Add missing break statement in order to prevent the code from falling
    > through to case SMU_Discrete_DpmTable.
    >
    > This bug was found thanks to the ongoing efforts to enable
    > -Wimplicit-fallthrough.
    >
    > Fixes: 34a564eaf528 ("drm/amd/powerplay: implement fw image related smum interface for Polaris.")
    > Cc: stable@vger.kernel.org
    > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>

    Already fixed:
    https://cgit.freedesktop.org/~agd5f/linux/commit/?h=drm-next-5.2-wip&id=6feaa4194c18578623565017f95d1b2f6b243567

    Alex

    > ---
    > drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
    > index 52abca065764..222fb79d319e 100644
    > --- a/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
    > +++ b/drivers/gpu/drm/amd/powerplay/smumgr/polaris10_smumgr.c
    > @@ -2330,6 +2330,7 @@ static uint32_t polaris10_get_offsetof(uint32_t type, uint32_t member)
    > case DRAM_LOG_BUFF_SIZE:
    > return offsetof(SMU74_SoftRegisters, DRAM_LOG_BUFF_SIZE);
    > }
    > + break;
    > case SMU_Discrete_DpmTable:
    > switch (member) {
    > case UvdBootLevel:
    > --
    > 2.21.0
    >
    > _______________________________________________
    > dri-devel mailing list
    > dri-devel@lists.freedesktop.org
    > https://lists.freedesktop.org/mailman/listinfo/dri-devel

    \
     
     \ /
      Last update: 2019-03-02 00:55    [W:3.885 / U:0.052 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site