Messages in this thread | | | Subject | Re: [PATCH 02/15] ARM: bcm: fix a leaked reference by addingmissing of_node_put | From | Florian Fainelli <> | Date | Fri, 1 Mar 2019 10:28:59 -0800 |
| |
On 3/1/19 12:56 AM, Wen Yang wrote: > The call to of_get_next_child returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/arm/mach-bcm/board_bcm281xx.c:43:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 35, but without a corresponding object release within this function.
This looks fine, if you resubmit, can you add a missing space between "adding" and "missing"? This applies to all of your patches, so I am assuming you somehow scripted that, which should be easy to fix.
With that changed:
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> -- Florian
| |