lkml.org 
[lkml]   [2019]   [Feb]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH net-next 01/16] Documentation: networking: switchdev: Update port parent ID section
    Sat, Feb 09, 2019 at 01:32:33AM CET, f.fainelli@gmail.com wrote:
    >Update the section about switchdev drivers having to implement a
    >switchdev_port_attr_get() function to return
    >SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after
    >commit bccb30254a4a ("net: Get rid of
    >SWITCHDEV_ATTR_ID_PORT_PARENT_ID").
    >
    >Fixes: bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID")
    >Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
    >---
    > Documentation/networking/switchdev.txt | 10 +++++-----
    > 1 file changed, 5 insertions(+), 5 deletions(-)
    >
    >diff --git a/Documentation/networking/switchdev.txt b/Documentation/networking/switchdev.txt
    >index f3244d87512a..2842f63ad47b 100644
    >--- a/Documentation/networking/switchdev.txt
    >+++ b/Documentation/networking/switchdev.txt
    >@@ -92,11 +92,11 @@ device.
    > Switch ID
    > ^^^^^^^^^
    >
    >-The switchdev driver must implement the switchdev op switchdev_port_attr_get
    >-for SWITCHDEV_ATTR_ID_PORT_PARENT_ID for each port netdev, returning the same
    >-physical ID for each port of a switch. The ID must be unique between switches
    >-on the same system. The ID does not need to be unique between switches on
    >-different systems.
    >+The switchdev driver must implement the net_device operation
    >+ndo_get_port_parent_id for each port netdev, returning the same physical ID

    Double space. Otherwise, this looks fine.

    Acked-by: Jiri Pirko <jiri@mellanox.com>


    >+for each port of a switch. The ID must be unique between switches on the same
    >+system. The ID does not need to be unique between switches on different
    >+systems.
    >
    > The switch ID is used to locate ports on a switch and to know if aggregated
    > ports belong to the same switch.
    >--
    >2.17.1
    >

    \
     
     \ /
      Last update: 2019-02-09 18:32    [W:3.264 / U:0.588 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site