Messages in this thread | | | Date | Fri, 8 Feb 2019 20:12:47 +0200 | From | Mike Rapoport <> | Subject | Re: [PATCH 0/3] generic asm: mman cleanup |
| |
On Fri, Feb 08, 2019 at 01:02:51AM -0500, Michael S. Tsirkin wrote: > Now that we have MAP_SHARED, MAP_PRIVATE and MAP_SHARED_VALIDATE on all > architectures, it probably makes sense to de-duplicate these > and put them into a common header.
I like the idea, but it seems there are more asm/mman.h users than just mpx and drm.
Any reason only those were updated to include linux/mman.h?
> Please review and consider merging though the generic tree. > > Build tested on x86 only. Has been in linux-next for a while now. > > Michael S. Tsirkin (3): > x86/mpx: tweak header name > drm: tweak header name > arch: move common mmap flags to linux/mman.h > > arch/alpha/include/uapi/asm/mman.h | 4 +--- > arch/mips/include/uapi/asm/mman.h | 4 +--- > arch/parisc/include/uapi/asm/mman.h | 4 +--- > arch/x86/mm/mpx.c | 2 +- > arch/xtensa/include/uapi/asm/mman.h | 4 +--- > include/drm/drmP.h | 3 +-- > include/uapi/asm-generic/mman-common.h | 4 +--- > include/uapi/linux/mman.h | 4 ++++ > 8 files changed, 11 insertions(+), 18 deletions(-) > > -- > MST >
-- Sincerely yours, Mike.
| |