Messages in this thread | | | Date | Fri, 8 Feb 2019 17:38:12 +0100 | From | Pablo Neira Ayuso <> | Subject | Re: [PATCH net-next] ethtool: Remove unnecessary null check in ethtool_rx_flow_rule_create |
| |
On Thu, Feb 07, 2019 at 09:46:53PM -0700, Nathan Chancellor wrote: > net/core/ethtool.c:3023:19: warning: address of array > 'ext_m_spec->h_dest' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (ext_m_spec->h_dest) { > ~~ ~~~~~~~~~~~~^~~~~~ > > h_dest is an array, it can't be null so remove this check. > > Fixes: eca4205f9ec3 ("ethtool: add ethtool_rx_flow_spec to flow_rule structure translator") > Link: https://github.com/ClangBuiltLinux/linux/issues/353 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Acked-by: Pablo Neira Ayuso <pablo@netfilter.org>
Thanks!
| |