lkml.org 
[lkml]   [2019]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v8 1/6] fieldbus_dev: add Fieldbus Device subsystem.
On Fri, Feb 8, 2019 at 7:18 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> > +static DEFINE_IDA(fieldbus_ida);
>
> You forget to destroy this ida structure when the module is removed.
> It's a common thing to get wrong :(
>

But fieldbus_ida is allocated on the heap. So as long as calls to
ida_simple_get() and ida_simple_remove() are matched, there
should be no resource leak?

What am I missing?

\
 
 \ /
  Last update: 2019-02-08 17:31    [W:0.076 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site