lkml.org 
[lkml]   [2019]   [Feb]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] tpm: Unify the send callback behaviour
From
Date
On 2/8/19 10:42 AM, Jarkko Sakkinen wrote:
> On Fri, Feb 08, 2019 at 09:42:16AM -0500, Stefan Berger wrote: > On 2/8/19 9:05 AM, Jarkko Sakkinen wrote:
>> At least tpm_nsc_send (tpm_nsc.c) and tpm_inf_send (tpm_infineon.c) are also
>> returning the number of bytes sent. I would consider tpm_crb the outlier
>> that returns 0 and should return the length even though we don't need it...
> That would be absolutely wrong way the fix the *actual* issue i.e.
> callbacks returning garbage (sometimes just passing the length parameter
> back as a return value).

Then I guess you have to fixes those other two files as well...

>
> /Jarkko
>

\
 
 \ /
  Last update: 2019-02-08 16:47    [W:0.066 / U:0.272 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site