Messages in this thread | | | From | "Bean Huo (beanhuo)" <> | Subject | RE: [EXT] Re: [PATCH] include: mtd: spi-nor: change HWCPAS to HWCAPS | Date | Fri, 8 Feb 2019 11:39:42 +0000 |
| |
Hi, Tudor
>SNOR_HWCPAS_READ_OCTO was renamed to SNOR_HWCPAS_READ_OCTAL >please update your remote and send a new patch. > Which branch do you mean? I checked linux-mtd, not renamed yet.
>The patch prefix is wrong, it should be prefixed with "mtd: spi-nor:". When in >doubt, you can check how were prefixed previous patches on the same file by >running something like: > >git log --oneline include/linux/mtd/spi-nor.h > >On 02/07/2019 03:46 PM, Bean Huo (beanhuo) wrote: >> > >This looks like a blank line, it's not needed, remove it please. >> Maybe this is wrong abbreviation, change from HWCPAS to HWCAPS. > >Indeed, it is, use imperative, something like: "Fix wrong abbreviation, >s/HWCPAS/HWCAPS" >> >> Signed-off-by: Bean Huo <beanhuo@micron.com> > >Your S-o-b tag doesn't match the author name, please fix this as well.
It is automatically added by git, what is correct way? Thanks, //Bean
| |