Messages in this thread | | | Date | Fri, 8 Feb 2019 14:28:40 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH 1/2] Drivers: hv: vmbus: Change server monitor_pages index to 0 |
| |
On Fri, 8 Feb 2019 04:58:52 -0500 Kimberly Brown <kimbrownkd@gmail.com> wrote:
> Change the monitor_pages index in server_monitor_pending_show() to '0'. > '0' is the correct monitor_pages index for the server. A comment for the > monitor_pages field in the vmbus_connection struct definition indicates > that the 1st page is for parent->child notifications. In addition, the > server_monitor_latency_show() and server_monitor_conn_id_show() > functions use monitor_pages index '0'. > > Signed-off-by: Kimberly Brown <kimbrownkd@gmail.com> > --- > drivers/hv/vmbus_drv.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c > index 403fee01572c..f2a79f5129d7 100644 > --- a/drivers/hv/vmbus_drv.c > +++ b/drivers/hv/vmbus_drv.c > @@ -234,7 +234,7 @@ static ssize_t server_monitor_pending_show(struct device *dev, > return -ENODEV; > return sprintf(buf, "%d\n", > channel_pending(hv_dev->channel, > - vmbus_connection.monitor_pages[1])); > + vmbus_connection.monitor_pages[0])); > } > static DEVICE_ATTR_RO(server_monitor_pending);
Looks good.
I wonder if ever gets used though since it returned incorrect data...
Acked-by: Stephen Hemminger <stephen@networkplumber.org>
| |