lkml.org 
[lkml]   [2019]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] Input: ps2-gpio - flush TX work when closing port
    On Thu, Feb 07, 2019 at 02:27:40PM -0800, Dmitry Torokhov wrote:
    > To ensure that TX work is not running after serio port has been torn down,
    > let's flush it when closing the port.
    >
    > Reported-by: Sven Van Asbroeck <thesven73@gmail.com>
    > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
    > ---
    > drivers/input/serio/ps2-gpio.c | 1 +
    > 1 file changed, 1 insertion(+)
    >
    > diff --git a/drivers/input/serio/ps2-gpio.c b/drivers/input/serio/ps2-gpio.c
    > index c62cceb97bb1..9e1dbde2e15b 100644
    > --- a/drivers/input/serio/ps2-gpio.c
    > +++ b/drivers/input/serio/ps2-gpio.c
    > @@ -76,6 +76,7 @@ static void ps2_gpio_close(struct serio *serio)
    > {
    > struct ps2_gpio_data *drvdata = serio->port_data;
    >
    > + flush_work(&drvdata->tx_work.work);

    Ah, we have flush_delayed_work() now, I'll change it before committing
    once we agree on the patch in principle.

    > disable_irq(drvdata->irq);
    > }
    >
    > --
    > 2.20.1.611.gfbb209baf1-goog
    >
    >
    > --
    > Dmitry

    --
    Dmitry

    \
     
     \ /
      Last update: 2019-02-07 23:32    [W:5.632 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site