lkml.org 
[lkml]   [2019]   [Feb]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH V14 3/5] i2c: tegra: Add DMA support
    From
    Date
    07.02.2019 21:56, Sowjanya Komatineni пишет:
    >
    >>> static const struct tegra_i2c_hw_feature tegra210_i2c_hw = { @@
    >>> -980,6 +1302,7 @@ static const struct tegra_i2c_hw_feature tegra210_i2c_hw = {
    >>> .has_mst_fifo = false,
    >>> .quirks = &tegra_i2c_quirks,
    >>> .supports_bus_clear = true,
    >>> + .has_apb_dma = true,
    >>> };
    >>
    >> T186 is missed here.
    >
    > Currently t186 hw feature is not present in existing linux next and device trees use both t186 and t114 compatibles, so t114 is being applies.
    > But dmas are not used for t186 yet.
    >
    > T186 hw feature is added for first time as part of interface timing and its in patch next to this patch in same series.
    > This is the same from beginning of all these series.
    >
    >>
    >>>
    >>> static const struct tegra_i2c_hw_feature tegra194_i2c_hw = { @@
    >>> -995,6 +1318,7 @@ static const struct tegra_i2c_hw_feature tegra194_i2c_hw = {
    >>> .has_mst_fifo = true,
    >>> .quirks = &tegra194_i2c_quirks,
    >>> .supports_bus_clear = true,
    >>> + .has_apb_dma = false,
    >>> };
    >

    You added "has_apb_dma" for T194 and not T186 in this patch, I happened to notice it only right now. Please, let's be consistent and set the new field for all of the platforms in this patch.

    \
     
     \ /
      Last update: 2019-02-07 20:03    [W:3.857 / U:0.080 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site