| Subject | Re: [PATCH 33/35] ARM: davinci: prepare to remove mach/irqs.h | From | Sekhar Nori <> | Date | Thu, 7 Feb 2019 19:37:40 +0530 |
| |
On 31/01/19 7:09 PM, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bgolaszewski@baylibre.com> > > Since we now select SPARSE_IRQ in davinci, the mach/irqs.h header is > no longer included from asm/irq.h. All interrupt numbers for devices > should be defined as platform device resources. Let's prepare for the > removal of mach/irqs.h by moving all defines that we want to keep to > relevant headers (davinci.h, common.h) and replacing others with > simple literals. > > Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com> > --- > arch/arm/mach-davinci/board-da830-evm.c | 2 +- > arch/arm/mach-davinci/board-da850-evm.c | 4 ++-- > arch/arm/mach-davinci/board-dm644x-evm.c | 2 +- > arch/arm/mach-davinci/board-dm646x-evm.c | 2 +- > arch/arm/mach-davinci/da830.c | 2 +- > arch/arm/mach-davinci/da850.c | 2 +- > arch/arm/mach-davinci/davinci.h | 2 ++ > arch/arm/mach-davinci/include/mach/common.h | 5 +++++ > arch/arm/mach-davinci/include/mach/irqs.h | 18 ------------------ > 9 files changed, 14 insertions(+), 25 deletions(-) > > diff --git a/arch/arm/mach-davinci/board-da830-evm.c b/arch/arm/mach-davinci/board-da830-evm.c > index b3a0148f7f1a..950e98e4eda5 100644 > --- a/arch/arm/mach-davinci/board-da830-evm.c > +++ b/arch/arm/mach-davinci/board-da830-evm.c > @@ -488,7 +488,7 @@ static int da830_evm_ui_expander_teardown(struct i2c_client *client, int gpio, > } > > static struct pcf857x_platform_data __initdata da830_evm_ui_expander_info = { > - .gpio_base = DAVINCI_N_GPIO, > + .gpio_base = 144,
Why drop DAVINCI_N_GPIO instead of just moving it to a local header file?
Thanks, Sekhar
|