Messages in this thread | | | From | Michael Ellerman <> | Subject | Re: [PATCH v2] powerpc/mm: move a KERN_WARNING message to pr_debug() | Date | Thu, 07 Feb 2019 15:33:57 +1100 |
| |
Hi Laurent,
I'm not sure I'm convinced about this one. It seems like we're just throwing away the warning because it's annoying.
Laurent Vivier <lvivier@redhat.com> writes: > resize_hpt_for_hotplug() reports a warning when it cannot > increase the hash page table ("Unable to resize hash page > table to target order") but this is not blocking and > can make user thinks something has not worked properly.
Something did not work properly, the resize didn't work properly. Right?
> As we move the message to the debug area, report again the > ENODEV error. > > If the operation cannot be done the real error message > will be reported by arch_add_memory() if create_section_mapping() > fails.
Can you explain that more. Isn't the fact that the resize failed "the real error message"?
> Fixes: 7339390d772dd > powerpc/pseries: Don't give a warning when HPT resizing isn't available
This should all be on one line, and formatted as:
Fixes: 7339390d772d ("powerpc/pseries: Don't give a warning when HPT resizing isn't available")
See Documentation/process/submitting-patches.rst for more info and how to configure git to do it automatically for you.
cheers
| |