lkml.org 
[lkml]   [2019]   [Feb]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 14/53] perf hist: Remove the needless callchain.h include from hist.h
    Date
    From: Arnaldo Carvalho de Melo <acme@redhat.com>

    Nothing that is provided by callchain.h is used there, just things that
    should've be directly included in hist.h, such as rbtree.h and a
    map_symbol forward declaration.

    Remove it so that we reduce the headers dependency tree.

    Cc: Adrian Hunter <adrian.hunter@intel.com>
    Cc: Jiri Olsa <jolsa@kernel.org>
    Cc: Namhyung Kim <namhyung@kernel.org>
    Link: https://lkml.kernel.org/n/tip-zivvqfx93w5zzur7hr7h0nlh@git.kernel.org
    Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
    ---
    tools/perf/util/hist.h | 3 ++-
    1 file changed, 2 insertions(+), 1 deletion(-)

    diff --git a/tools/perf/util/hist.h b/tools/perf/util/hist.h
    index 38a72eb81427..6b872079ead5 100644
    --- a/tools/perf/util/hist.h
    +++ b/tools/perf/util/hist.h
    @@ -2,9 +2,9 @@
    #ifndef __PERF_HIST_H
    #define __PERF_HIST_H

    +#include <linux/rbtree.h>
    #include <linux/types.h>
    #include <pthread.h>
    -#include "callchain.h"
    #include "evsel.h"
    #include "header.h"
    #include "color.h"
    @@ -13,6 +13,7 @@
    struct hist_entry;
    struct hist_entry_ops;
    struct addr_location;
    +struct map_symbol;
    struct mem_info;
    struct branch_info;
    struct symbol;
    --
    2.20.1
    \
     
     \ /
      Last update: 2019-02-06 19:55    [W:3.230 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site