Messages in this thread | | | Subject | Re: [PATCH 2/2] staging/vboxvideo: Add TODO | From | Hans de Goede <> | Date | Wed, 6 Feb 2019 17:13:47 +0100 |
| |
Hi,
On 06-02-19 16:58, Daniel Vetter wrote: > On Mon, Feb 04, 2019 at 07:54:16PM +0100, Sam Ravnborg wrote: >> Hi Daniel >> >> On Mon, Feb 04, 2019 at 11:31:14AM +0100, Daniel Vetter wrote: >>> Noticed why wonder what vboxvideo is using the ->master_set/drop hooks >>> for. >> Can you improve the gammar a little, I find it hard to read. >> >>> >>> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> >>> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> >>> Cc: Fabio Rafael da Rosa <fdr@pid42.net> >>> Cc: Nicholas Mc Guire <der.herr@hofr.at> >>> Cc: Daniel Vetter <daniel.vetter@ffwll.ch> >>> Cc: Hans de Goede <hdegoede@redhat.com> >>> --- >>> drivers/staging/vboxvideo/TODO | 2 ++ >>> 1 file changed, 2 insertions(+) >>> >>> diff --git a/drivers/staging/vboxvideo/TODO b/drivers/staging/vboxvideo/TODO >>> index 2e0f99c3f10c..2953e7f794fb 100644 >>> --- a/drivers/staging/vboxvideo/TODO >>> +++ b/drivers/staging/vboxvideo/TODO >>> @@ -1,5 +1,7 @@ >>> TODO: >>> -Get a full review from the drm-maintainers on dri-devel done on this driver >>> +-Drop all the logic around initial_mode_queried/master_set&_drop and everything >>> +related to this. kms clients can handle hotplugs. >>> -Extend this TODO with the results of that review >>> >>> Please send any patches to Greg Kroah-Hartman <gregkh@linuxfoundation.org>, >> >> The syntax around "master_set&_drop" could be better. >> I wondered if the "&" was some rst syntax. >> >> But anyway, despite grammar nit and syntax nit: >> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > > Both patches queued for 5.1 in drm-misc, thanks for taking a look. > >> Which bring me back to a question asked a week ago or so. >> What is missing before we can move vboxvideo out of staging/ > > I think it boils down to someone needs to submit it and we'll take a look.
Right, I have this on my TODO, but I did not manage to find time for this the past few weeks. I expect to have time for this in a couple of weeks from now, which means the move will miss the 5.1 merge window.
Note you (Sam) are certainly welcome to submit a patch doing the move yourself, I can certainly use some help with maintaining vboxvideo.
Note I will be available to help answer questions resulting from a review for moving the driver out of staging. And more in general, if you want to do this I will try to help where I can.
Regards,
Hans
| |