Messages in this thread | | | From | Sven Van Asbroeck <> | Date | Wed, 6 Feb 2019 09:33:53 -0500 | Subject | Re: [PATCH] Input: cap11xx - switch to using set_brightness_blocking() |
| |
On Tue, Feb 5, 2019 at 5:20 PM Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > > Updating LED state requires access to regmap and therefore we may sleep, so > we could not do that directly form set_brightness() method. Historically > we used private work to adjust the brightness, but with the introduction of > set_brightness_blocking() we no longer need it. >
Elegant solution, nice !
I read the patch to verify that the user-after-free is now gone, but obviously I cannot test, as I have no cap11xx hardware. For what it's worth:
Reviewed-by: Sven Van Asbroeck <TheSven73@googlemail.com>
| |