lkml.org 
[lkml]   [2019]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v1 2/4] dt-bindings: clock: Add support for the MSM8998 mmcc
From
Date
On 2/5/2019 3:02 PM, Stephen Boyd wrote:
> Quoting Jeffrey Hugo (2019-01-30 08:35:59)
>> Document the multimedia clock controller found on MSM8998
>>
>> Signed-off-by: Jeffrey Hugo <jhugo@codeaurora.org>
>> ---
>> Documentation/devicetree/bindings/clock/qcom,mmcc.txt | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>> index 8b0f784..ae85bca 100644
>> --- a/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>> +++ b/Documentation/devicetree/bindings/clock/qcom,mmcc.txt
>> @@ -10,11 +10,18 @@ Required properties :
>> "qcom,mmcc-msm8960"
>> "qcom,mmcc-msm8974"
>> "qcom,mmcc-msm8996"
>> + "qcom,mmcc-msm8998"
>>
>> - reg : shall contain base register location and length
>> - #clock-cells : shall contain 1
>> - #reset-cells : shall contain 1
>>
>> +For MSM8998 only:
>> + - clocks: a list of phandles and clock-specifier pairs,
>> + one for each entry in clock-names.
>> + - clock-names: "xo" for the xo clock,
>> + "gpll0" for the global pll 0 clock.
>
> Wouldn't the DSI plls also be listed here? And anything else that is
> external to this clock controller?
>

We can't get the DSI plls from DT as far as I am aware (upstream). That
is why I mentioned in the cover letter we need to rely on the global
namespace.

Also, the DSI plls, etc present a chicken and egg situation, as the plls
require mmcc, and mmcc requires the plls. I forsee an unsolvable
EPROBE_DEFER issue.

--
Jeffrey Hugo
Qualcomm Datacenter Technologies as an affiliate of Qualcomm
Technologies, Inc.
Qualcomm Technologies, Inc. is a member of the
Code Aurora Forum, a Linux Foundation Collaborative Project.

\
 
 \ /
  Last update: 2019-02-05 23:09    [W:0.051 / U:12.688 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site