Messages in this thread | | | Date | Tue, 5 Feb 2019 21:27:15 +0100 | From | Luc Van Oostenryck <> | Subject | Re: [PATCH] build_bug.h: add wrapper for _Static_assert |
| |
On Tue, Feb 05, 2019 at 10:53:31AM +0100, Rasmus Villemoes wrote: > On 05/02/2019 00.12, Andrew Morton wrote: > >> > >> It would be (very) nice to actually use this macro in a few places so > >> it gets its build testing while in -next. > > > > ie, just about every BUILD_BUG_ON in mm/ could use this. Let's switch > > a few? > > > > Perhaps, but some make sense where they are, e.g. when iterating over > two arrays using one iterator variable, it's fine to assert they have > the same size just above the loop. And, unfortunately, static_assert() > is not quite a drop-in replacement for BUILD_BUG_ON even when the > argument is an ICE due to -Wdeclaration-after-statement.
Yes, unfortunately.
-- Luc
| |